jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.
Approved after removing the curly brackets.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:136
continue;
if (entry_or->getCUOffset() != cu_offset)
continue;
----------------
It would be nice to reverse these two comparisons for `found_entry_for_cu` but
`getCUOffset()` is much more expensive. Just saying.
================
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:149-151
+ if (!found_entry_for_cu) {
+ m_fallback.GetGlobalVariables(cu, callback);
+ }
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106355/new/
https://reviews.llvm.org/D106355
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
