teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
I'm landing this to unbreak Green Dragon. @mgorny Just a heads up, I think this also broke one test with debugserver: ====================================================================== FAIL: test_platform_file_wronly_trunc_debugserver (TestGdbRemotePlatformFile.TestGdbRemotePlatformFile) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/teemperor/1llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py", line 52, in test_method return attrvalue(self) File "/Users/teemperor/1llvm/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 119, in wrapper func(*args, **kwargs) File "/Users/teemperor/1llvm/llvm-project/lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py", line 42, in test_platform_file_wronly_trunc self.vFile_test(write=True, trunc=True) File "/Users/teemperor/1llvm/llvm-project/lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py", line 146, in vFile_test context = self.expect_gdbremote_sequence() File "/Users/teemperor/1llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py", line 621, in expect_gdbremote_sequence return expect_lldb_gdbserver_replay( File "/Users/teemperor/1llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py", line 198, in expect_lldb_gdbserver_replay context = sequence_entry.assert_match( File "/Users/teemperor/1llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py", line 479, in assert_match return self._assert_regex_match(asserter, actual_packet, context) File "/Users/teemperor/1llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py", line 446, in _assert_regex_match asserter.fail( AssertionError: regex '^\$F([0-9a-fA-F]+)#[0-9a-fA-F]{2}$' failed to match against content '$#00' Config=x86_64-/Users/teemperor/1llvm/rel/bin/clang -------------------------------------------------------- ( TestGdbRemotePlatformFile's different subtests fail with same/similar errors). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits