teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
In D108817#2972047 <https://reviews.llvm.org/D108817#2972047>, @HirokiImai wrote: > Thanks for the review! > I didn't know how to write tests very well, so the review was very helpful > for me. > I found the LLVM project to be beautiful in its componentization. I'll learn > more about it. You're welcome and thanks for the patch! I'll merge this for you. Small note: The test here is not how tests are usually written. The test here has to spawn a virtual terminal to test the command line interface (editline) code, so that's why it uses the special `PExpectTest` test class. You might want to check out tests that were recently added to the `lldb/test/API` folder to see how LLDB tests usually look like. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108817/new/ https://reviews.llvm.org/D108817 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
