labath added inline comments.
================
Comment at: lldb/include/lldb/Host/Terminal.h:21
public:
+ struct Data;
+
----------------
Move this into the protected section
================
Comment at: lldb/source/Host/common/Terminal.cpp:76
+ struct termios &fd_termios = data->m_termios;
+ bool set_corectly = false;
+ if (enabled) {
----------------
mgorny wrote:
> My gut feeling is telling me that this can be simplified somehow… or we could
> assume `tcsetattr()` is cheap and just do the change unconditionally.
yeah, I think it'd be fine to call tcsetattr unconditionally
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111890/new/
https://reviews.llvm.org/D111890
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
