teemperor added a comment.
In D111686#3079248 <https://reviews.llvm.org/D111686#3079248>, @clayborg wrote:
> So there is a buildbot failure due to an expression which succeeds, but
> because the "expression" command options don't apply cleanly to the
> expression result the "expression" command fails. Question: do we want
> "expressionEvaluation" to truly track expression evaluation failures, or just
> track the "expression" command success and fails? I updated this patch to
> track expression failures only by modifying the Target::EvaluateExpression(),
> so if this succeeds and "expr" command fails, we consider the expression a
> success right now.
I have to look into this but could we skip that test in the meantime?
There is also another failure that looks like it's caused by some accidental
change (see inline)
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:761
+ def getShlibBuildArtifact(self, DYLIB_NAME):
+ """Return absolute path to a shared library artifact given the library
----------------
clayborg wrote:
> wallace wrote:
> > is this actually used somewhere?
> Not yet, I will remove it
I think you also removed some existing stuff here:
```
PASS: LLDB (C:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe-x86_64) ::
test_zero_uuid_modules (TestMiniDumpUUID.MiniDumpUUIDTestCase)
======================================================================
ERROR: test_relative_module_name (TestMiniDumpUUID.MiniDumpUUIDTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\API\functionalities\postmortem\minidump-new\TestMiniDumpUUID.py",
line 317, in test_relative_module_name
self.getSourcePath("relative_module_name.yaml"))
AttributeError: 'MiniDumpUUIDTestCase' object has no attribute 'getSourcePath'
Config=x86_64-C:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111686/new/
https://reviews.llvm.org/D111686
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
