dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Alternatively the string concatenation could be inlined, then the Twine usage
would be correct - but would still need an explicit "str()", like this:
SendPacketAndWaitForResponse(("QEnableCompression:type:" + avail_name +
";").str(), response)
Which may or may not be marginally faster because the Twine could cheaply
compute the total length of the required buffer/presize the string... maybe.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113314/new/
https://reviews.llvm.org/D113314
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
