JDevlieghere added a comment.
A few small nits but I'm very happy with the approach. Thanks Larry!
================
Comment at: lldb/include/lldb/API/SBHostOS.h:23
+ const char *GetScriptInterpreterInfo();
+
----------------
Is still still relevant?
================
Comment at: lldb/test/API/functionalities/paths/TestPaths.py:50
+ info_sd =
self.dbg.GetScriptInterpreterInfo(self.dbg.GetScriptingLanguage("python"))
+ assert info_sd.IsValid()
+ stream = lldb.SBStream()
----------------
================
Comment at: lldb/test/API/functionalities/paths/TestPaths.py:51
+ assert info_sd.IsValid()
+ stream = lldb.SBStream()
+ assert info_sd.GetAsJSON(stream).Success()
----------------
Might be nice to check that all the keys you expect for Python are in the
structured data, either here or in a separate test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112973/new/
https://reviews.llvm.org/D112973
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
