JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py:40-43
+ lldbutil.run_to_breakpoint_make_target(self)
+
lldbutil.run_break_set_by_source_regexp(self, "// break here", "-f
main.cpp")
self.runCmd("run")
----------------
jingham wrote:
> You don't need to do this in three steps, do you? Can't you just use
> lldbutil.run_to_source_breakpoint? That will catch errors in running &
> hitting the breakpoint which you don't check here.
Yes, that would work here, but not for the test above. I'll update the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114819/new/
https://reviews.llvm.org/D114819
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
