aprantl added a comment.
Thanks! I have some late wording suggestions.
================
Comment at: lldb/source/Target/StackFrame.cpp:1904
+ strm.Printf("Warning: the current PC is an artificial location "
+ "in function %s.",
+ fn_name.AsCString());
----------------
This message might be confusing to developers. End-users won't know what "PC"
and "artificial" means. What do you think about:
```
"Note: this address is compiler-generated code in function %s that has no
source code associated with it."
```
?
================
Comment at: lldb/source/Target/StackFrame.cpp:1909
+ "Warning: the current PC is an artificial location "
+ "but lldb couldn't associate it with a function in %s.",
+ m_sc.line_entry.file.GetFilename().GetCString());
----------------
"Note: this address is compiler-generated code that has no source code
associated with it."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115313/new/
https://reviews.llvm.org/D115313
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
