MaskRay accepted this revision. MaskRay added subscribers: hubert.reinterpretcast, Kai. MaskRay added a comment. This revision is now accepted and ready to land.
> Plus llvm/Support/Errc.h not included by a bunch of > llvm/DebugInfo/DWARF/DWARF*.h files You may check whether we can just get rid of `llvm/include/llvm/Support/Errc.h` in favor of `<system_error>`. It (https://reviews.llvm.org/rG2a826e40fa51fcae4adb564d789cafe95776e0bb 2014-06) could be related to ancient MSVC workaround which may not be relevant today (we now require Visual Studio 2019 or later). CC @Kai @hubert.reinterpretcast for z/OS / AIX. ================ Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:40 using namespace object; +namespace llvm { +class DWARFDebugInfoEntry; ---------------- There is usually a blank line between `using namespace` and `namespace llvm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119723/new/ https://reviews.llvm.org/D119723 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits