mgorny added inline comments.
Herald added a project: All.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbpexpect.py:27
+ def launch(self, executable=None, extra_args=None, timeout=60,
+ dimensions=None, run_under=None, post_spawn=None):
logfile = getattr(sys.stdout, 'buffer',
----------------
I think we should follow PEP8 for Python code, i.e. align the first param with
the first param from line above.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbpexpect.py:32
+ args = []
+ if run_under:
+ args += run_under
----------------
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbpexpect.py:51
+
+ if post_spawn:
+ post_spawn()
----------------
================
Comment at: lldb/test/API/driver/job_control/shell.py:9
+import os
+
+def preexec_fn():
----------------
================
Comment at: lldb/test/API/driver/job_control/shell.py:23
+ signal.pthread_sigmask(signal.SIG_SETMASK, orig_mask)
+
+if __name__ == "__main__":
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120320/new/
https://reviews.llvm.org/D120320
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
