labath added subscribers: cmtice, labath.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I like this.



================
Comment at: lldb/tools/lldb-fuzzer/lldb-fuzzer-target.cpp:24
+extern "C" int LLVMFuzzerTestOneInput(uint8_t *data, size_t size) {
+  auto file = TempFile::Create(data, size);
+  if (!file)
----------------
Not an ideal use of auto -- it's clear that this returns some form of TempFile, 
but if this were say Expected<TempFile>, then the code would be incorrect (but 
still compile).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122461/new/

https://reviews.llvm.org/D122461

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to