aprantl added inline comments.
================ Comment at: lldb/include/lldb/Target/Platform.h:102 + static lldb::PlatformSP + GetPlatformForArchitectures(std::vector<ArchSpec> archs, ---------------- Would you mind adding a doxygen comment for this? I'm asking because the semantics are not clear to me just from looking at the function signature. ================ Comment at: lldb/source/Target/Platform.cpp:1228 + platforms.erase(std::unique(platforms.begin(), platforms.end()), + platforms.end()); +} ---------------- would std::unique be more idiomatic? ================ Comment at: lldb/unittests/Platform/PlatformTest.cpp:1 +//===-- PlatformTest.cpp ------------------------------------===// +// ---------------- super-nit: too few `-`s :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122684/new/ https://reviews.llvm.org/D122684 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
