[Lldb-commits] [PATCH] D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Utility/TraceGDBRemotePackets.cpp:136
                             {"tid", packet.tid},
-                            {"size", packet.size}});
+                            {"size", static_cast<int64_t>(packet.size)}});
 }
----------------
jj10306 wrote:
> why is this needed now? I thought that unsigned ints were now supported by 
> the json lib. 
> is this temporary because of the bug you address in D125322?
i just need to rebase :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125047/new/

https://reviews.llvm.org/D125047

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits