mib accepted this revision.
mib added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/examples/python/crashlog.py:1025-1027
- except Exception as e:
- result.PutCString("error: python exception: %s" % e)
- return
----------------
JDevlieghere wrote:
> mib wrote:
> > What about printing the exception backtrace and exiting cleaning instead of
> > crashing ?
> What's the advantage?
>
> - LLBB's embedded python interpreter is going to catch the exception and
> put the crash info in the command result object.
> - When running directly under Python, the default exception handler is
> going to print the backtrace as well.
Alright, LGTM then
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125589/new/
https://reviews.llvm.org/D125589
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
