[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/source/Interpreter/embedded_interpreter.py:49-52
+    if line == 'exit':
+        raise LLDBExit
+    if line == 'quit':
+        raise LLDBExit
----------------
could do:
```
if line in ('exit', 'quit'):
```


================
Comment at: lldb/test/Shell/ScriptInterpreter/Python/exit.test:1-5
+# RUN: %lldb -o 'script quit' | FileCheck %s --check-prefix SILENT
+# RUN: %lldb -o 'script quit()' | FileCheck %s --check-prefix SILENT
+
+# RUN: %lldb -o 'script exit' | FileCheck %s --check-prefix SILENT
+# RUN: %lldb -o 'script exit()' | FileCheck %s --check-prefix SILENT
----------------
is there a reason to support both with and without `()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127895/new/

https://reviews.llvm.org/D127895

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits