jhenderson added inline comments.
================ Comment at: llvm/include/llvm/ADT/Triple.h:864 /// Tests whether the target is RISC-V (32- and 64-bit). bool isRISCV() const { ---------------- Perhaps worth updating to mention big and little endian here, like `isPPC64` above? ================ Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:304-305 {"elf64-littleriscv", {ELF::EM_RISCV, true, true}}, + {"elf32-bigriscv", {ELF::EM_RISCV, false, false}}, + {"elf64-bigriscv", {ELF::EM_RISCV, true, false}}, // PowerPC ---------------- We need llvm-objcopy testing for these new targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits