labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good. The patch is really trivial so I don't want to make big deal out of the test. However, I would like to continue the discussion started in the patch description, as I think it would be very useful if we could figure out a way to make this test (and others) cross-platform, so we don't have to have two versions of all of them. I'm going to start by asking a couple of questions, just so I understand the problem better. You say that the issue is the lack of symtab in the "msvc" mode. What makes this test work then? Do some of the assembler directives (`.def`?) produce some sort of debug info entries? What determines the modes that clang is operating in? Is it the default target triple? What does `-Wl,-debug:symtab` actually produce? Would it make sense to make it a part of the `%clang_host` substitution (only for the msvc mode) to make the output of %clang_host more uniform? Or maybe achieve equivalence in some other way (add `-g1`, or similar, to the cmd line)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129455/new/ https://reviews.llvm.org/D129455 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
