fixathon marked 3 inline comments as done.
fixathon added a comment.
Addressed the comments. Will deal with the signed/unsigned issue in a separate
diff if still needed.
================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2582
surface.MoveCursor(0, 1);
surface.HorizontalLine(surface.GetWidth());
}
----------------
clayborg wrote:
> fixathon wrote:
> > Here we have HorizontalLine() function that requires non-negative input
> But surface.HorizontalLine(...) function takes an "int", and now we are
> passing it a uint32_t. If this function requires a >= 0 value, it should do
> the check internally
I agree. I've reverted the function signatures back to signed int and will
revisit the signed/unsigned issue in another diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131615/new/
https://reviews.llvm.org/D131615
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
