labath accepted this revision.
labath added inline comments.

================
Comment at: lldb/include/lldb/Utility/UUID.h:47
+  /// Creates a UUID from the data pointed to by the bytes argument. 
   static UUID fromData(const void *bytes, uint32_t num_bytes) {
     if (bytes)
----------------
The main reason this was a factory function was so that we could use the 
factory name to disambiguate between the two interpretations of zero "uuids".

As we're removing that, we could also go back to using regular constructors for 
object creation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132191/new/

https://reviews.llvm.org/D132191

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to