probinson added inline comments.
================
Comment at: clang/CMakeLists.txt:106
AND EXISTS ${UNITTEST_DIR}/CMakeLists.txt)
add_subdirectory(${UNITTEST_DIR} utils/unittest)
endif()
----------------
Should this be `third-party/unittest` ? Looking at how the lldb cmake files
were modified.
================
Comment at: lld/CMakeLists.txt:69
AND EXISTS ${UNITTEST_DIR}/CMakeLists.txt)
add_subdirectory(${UNITTEST_DIR} utils/unittest)
endif()
----------------
See comment for clang/CMakeLists.txt
================
Comment at: mlir/CMakeLists.txt:25
if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h)
add_subdirectory(${UNITTEST_DIR} utils/unittest)
endif()
----------------
See comment for clang/CMakeLists.txt
================
Comment at: polly/CMakeLists.txt:37
if (NOT TARGET gtest)
add_subdirectory(${UNITTEST_DIR} utils/unittest)
endif()
----------------
See comment for clang/CMakeLists.txt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131919/new/
https://reviews.llvm.org/D131919
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
