Author: Dave Lee Date: 2022-08-29T10:20:51-07:00 New Revision: 296f7614edcfb9ac52842d9b952d6eadb0ad6edf
URL: https://github.com/llvm/llvm-project/commit/296f7614edcfb9ac52842d9b952d6eadb0ad6edf DIFF: https://github.com/llvm/llvm-project/commit/296f7614edcfb9ac52842d9b952d6eadb0ad6edf.diff LOG: [lldb][test] Speed up lldb arch determination (NFC) While investigation slow tests, I looked into why `TestMultithreaded.py`. One of the reasons is that it determines the architecture of lldb by running: ``` lldb -o 'file path/to/lldb' -o 'quit' ``` On my fairly fast machine, this takes 24 seconds, and `TestMultithreaded.py` calls this function 4 times. With this change, this command now takes less than 0.2s on the same machine. The reason it's slow is symbol table and debug info loading, as indicated by the new progress events printed to the console. One setting reduced the time in half: ``` settings set target.preload-symbols false ``` Further investigation, by profiling with Instruments on macOS, showed that loading time was also caused by looking for scripts. The setting that eliminates this time is: ``` settings set target.load-script-from-symbol-file false ``` Differential Revision: https://reviews.llvm.org/D132803 Added: Modified: lldb/packages/Python/lldbsuite/test/lldbtest.py Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py index 0d449737cfd0b..46eac450c6ba0 100644 --- a/lldb/packages/Python/lldbsuite/test/lldbtest.py +++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py @@ -1255,21 +1255,23 @@ def getLldbArchitecture(self): """Returns the architecture of the lldb binary.""" if not hasattr(self, 'lldbArchitecture'): - # spawn local process + # These two target settings prevent lldb from doing setup that does + # nothing but slow down the end goal of printing the architecture. command = [ lldbtest_config.lldbExec, - "-o", - "file " + lldbtest_config.lldbExec, - "-o", - "quit" + "-x", + "-b", + "-o", "settings set target.preload-symbols false", + "-o", "settings set target.load-script-from-symbol-file false", + "-o", "file " + lldbtest_config.lldbExec, ] output = check_output(command) - str = output.decode("utf-8") + str = output.decode() for line in str.splitlines(): m = re.search( - "Current executable set to '.*' \\((.*)\\)\\.", line) + r"Current executable set to '.*' \((.*)\)\.", line) if m: self.lldbArchitecture = m.group(1) break _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
