yinghuitan marked an inline comment as done.
yinghuitan added a comment.
@jingham , @clayborg, thanks for the feedback.
Seems like the major concern is creating a general GetSettings() API instead of
API for each setting. I like and agree with this idea. Per the reading,
================
Comment at: lldb/test/API/functionalities/source-map/TestTargetSourceMap.py:25
+ src_dir = self.getSourceDir()
+ self.runCmd('settings set target.source-map . "%s"' % src_dir)
+
----------------
hawkinsw wrote:
> Sorry if this comment is not helpful, but I was wondering ...
>
> Could we use `source_map_setting_path` here? That would make future changes
> easier?
@hawkinsw, sorry, almost missed your comment. There is no single value for
source map path but a pair of original/replacement. In this case, original is
"." while the replacement is "src_dir" so I think src_dir makes sense here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133038/new/
https://reviews.llvm.org/D133038
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
