zequanwu marked 2 inline comments as done.
zequanwu added inline comments.
================
Comment at: lldb/test/Shell/SymbolFile/NativePDB/blocks.cpp:17
+
+// CHECK: Function: id = {{.*}}, name = "main", range =
[0x0000000140001000-0x000000014000104b)
+// CHECK-NEXT: FuncType: id = {{.*}}, byte-size = 0, compiler_type = "int
(void)"
----------------
labath wrote:
> I fear this test is going to be extremely fragile (susceptible to changes in
> codegen AND debug info generation). I'd probably write it in asm (you could
> even test the error msg then).
Done in https://reviews.llvm.org/rG603793698928c1f32772248840a45ddcf4914bd2.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133461/new/
https://reviews.llvm.org/D133461
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
