Author: Jason Molenda Date: 2022-09-09T17:37:46-07:00 New Revision: 30578c08568bc8de79dea72e41f49899ba10ea55
URL: https://github.com/llvm/llvm-project/commit/30578c08568bc8de79dea72e41f49899ba10ea55 DIFF: https://github.com/llvm/llvm-project/commit/30578c08568bc8de79dea72e41f49899ba10ea55.diff LOG: dependency cycle fix in DynamicLoaderDarwinKernel DynamicLoaderDarwinKernel calls in to PlatformDarwinKernel, and with my changes in https://reviews.llvm.org/D133534, PlatformDarwinKernel calls in to DynamicLoaderDarwinKernel. This results in a cmake dependency if accurately included in the link libraries list. lldbPluginDynamicLoaderDarwinKernel is specfically for kernel debugging and is uncommonly linked in to anything except a full lldb. lldbPluginPlatformMacOSX is any Darwin platform, including PlatformDarwinKernel, and is referenced a number of time in shell tests, for instance. I believe anything linking the darwin kernel DynamicLoader plugin will already have lldbPluginPlatformMacOSX in its dependency list, so not explicitly expressing this dependency is safe. Added: Modified: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt Removed: ################################################################################ diff --git a/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt b/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt index e29ddca343f9..fb838f42489d 100644 --- a/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt +++ b/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt @@ -17,7 +17,6 @@ add_lldb_library(lldbPluginDynamicLoaderDarwinKernel PLUGIN lldbSymbol lldbTarget lldbUtility - lldbPluginPlatformMacOSX ) add_dependencies(lldbPluginDynamicLoaderDarwinKernel _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
