[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

[Thorsten via Phabricator via lldb-commits]

tschuett added inline comments.


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:2379
+        // offset is compile unit relative so we need to fix it up.
+        die_offset += dwarf_cu->GetOffset();
         // FIXME: the constness has annoying ripple effects.
----------------
Do you need to give up the const or:
```
descriptive_offset = die_offset + dwarf_cu->GetOffset();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133623/new/

https://reviews.llvm.org/D133623

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits