Author: Dave Lee Date: 2022-10-01T09:58:40-07:00 New Revision: 557a19ab0fce115b66094ce68752e524af599ed9
URL: https://github.com/llvm/llvm-project/commit/557a19ab0fce115b66094ce68752e524af599ed9 DIFF: https://github.com/llvm/llvm-project/commit/557a19ab0fce115b66094ce68752e524af599ed9.diff LOG: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both high firing (tens of thousands of calls) and fast running (15 µs mean). Timers like this are noise and load for profiling systems, and can be removed. rdar://100326595 Differential Revision: https://reviews.llvm.org/D134920 Added: Modified: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp index 46204ba369eb..21ef765d1bba 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp @@ -51,8 +51,6 @@ void DWARFUnit::ExtractUnitDIENoDwoIfNeeded() { return; // Already parsed ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef()); - LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()", - GetOffset()); // Set the offset to that of the first DIE and calculate the start of the // next compilation unit header. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits