labath added inline comments.
================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h:116-118
+ GDBRemoteCommunication &GetCommunication() {
+ return m_comm;
+ }
----------------
Is the plan to make this private/protected at some point, or something like
that? Otherwise, I'm not really sure what's the benefit of this over the
regular inheritance.
I like the idea of using composition instead of inheritance (I think we could
do something similar with GDBRemoteCommunication and Communication), but right
now this seems fairly messy, and the benefit is unclear.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135029/new/
https://reviews.llvm.org/D135029
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
