aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
As much as I dislike expanding our hand-rolled parser, this does seem small and
important enough to warrant doing it!
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:260
+ Bookmark start_position = SetBookmark();
+ if (!ConsumeToken(tok::l_square)) {
+ return false;
----------------
nit: the function is inconsistent about whether to use curly braces on single
statements. LLVM style says don't.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136306/new/
https://reviews.llvm.org/D136306
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
