clayborg added inline comments.
================ Comment at: lldb/include/lldb/Symbol/CompilerDecl.h:93 + void GetCompilerContext( + llvm::SmallVectorImpl<lldb_private::CompilerContext> &context) const; + ---------------- clayborg wrote: > clayborg wrote: > > aprantl wrote: > > > aprantl wrote: > > > > Why can't this be a return value? The context objects are tiny. > > > ping? > > Will change! > I looked around LLVM code and there are many accessors that use this > technique. Otherwise we need to enforce an exact SmallVector type as the > return code and we can't use > "llvm::SmallVectorImpl<lldb_private::CompilerContext>". I can change this to > return a "llvm::SmallVector<CompilerContext, 4>" if needed? But that locks us > into a specific small vector with a specific size of preached items. change "preached" to "preset" above... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137900/new/ https://reviews.llvm.org/D137900 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
