mib marked an inline comment as done.
mib added inline comments.
================
Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:36
+
+ std::string GetClassName() const { return m_class_name; }
+ StructuredData::DictionarySP GetArgsSP() const { return m_args_sp; }
----------------
JDevlieghere wrote:
> Why return a copy? Can this be a StringRef?
I guess we can return a `StringRef` but the member type still needs to be
`std::string` to keep ownership.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139247/new/
https://reviews.llvm.org/D139247
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
