JDevlieghere added inline comments.
================ Comment at: lldb/bindings/python/python-wrapper.swig:317 +PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform( + const char *python_class_name, const char *session_dictionary_name, ---------------- This looks pretty similar to `LLDBSwigPythonCreateScriptedThread` and `LLDBSwigPythonCreateScriptedProcess`. Can we factor out the common parts? ================ Comment at: lldb/examples/python/scripted_process/scripted_platform.py:33 + + processes = { + 420: { ---------------- Why is this method implemented and not a `pass` like the others? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits