jingham added a comment. This seems okay to me, I can't see why you would be required to fill in the "main binary" or "extra binaries" when we're just stopping for the attach. We shouldn't need them till we've decided we're launched or attached and need to print any info about that.
But given that it was at one point important to call LoadStubBinaries AFTER you had a process, you should leave a comment saying why it is important to wait till you have a process before reading in more binaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141972/new/ https://reviews.llvm.org/D141972 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
