Author: Jim Ingham Date: 2023-01-20T15:41:59-08:00 New Revision: e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73
URL: https://github.com/llvm/llvm-project/commit/e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73 DIFF: https://github.com/llvm/llvm-project/commit/e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73.diff LOG: Remove the LINK_COMPONENTS entry from lldb-instr CMakery The presence of this entry causes the Xcode generator to produce two references to libLLVMSupport.a, one at the end of the list, and that causes the build to fail with a link error. The first version was pulled in when processing the CLANG_LIBS entries in the lldb/tools/lldb-instr/CMakeLists.txt. I looked around and the only places where we use LINK_COMPONENTS and CLANG_LIBS together are various lldb subdirectories that produce .a files but don't actually link anything. Anyway, this line doesn't seem to be needed for either the regular Ninja or the Xcode generator, and removing it makes the xcode build work again. Differential Revision: https://reviews.llvm.org/D142241 Added: Modified: lldb/tools/lldb-instr/CMakeLists.txt Removed: ################################################################################ diff --git a/lldb/tools/lldb-instr/CMakeLists.txt b/lldb/tools/lldb-instr/CMakeLists.txt index 8da453b2894fd..a1bbd7e2b7c93 100644 --- a/lldb/tools/lldb-instr/CMakeLists.txt +++ b/lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ add_lldb_tool(lldb-instr clangSerialization clangTooling - LINK_COMPONENTS - Support ) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits