dblaikie added inline comments.
================ Comment at: lldb/source/API/SBSection.cpp:187-189 + DataExtractorSP result_data_sp = + std::make_shared<DataExtractor>(section_data, offset, size); + sb_data.SetOpaque(result_data_sp); ---------------- Probably either use `std::move` when passing `result_data_sp` to `SetOpaque`, or roll the expressions together (to avoid an unnecessary copy of a ref counted smart pointer, that would cause extra increment/decrement of the ref count) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142672/new/ https://reviews.llvm.org/D142672 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
