Author: Jason Molenda Date: 2023-02-07T16:05:24-08:00 New Revision: b1d8f40484dfcb28b19c83aa33a674308b17e5dc
URL: https://github.com/llvm/llvm-project/commit/b1d8f40484dfcb28b19c83aa33a674308b17e5dc DIFF: https://github.com/llvm/llvm-project/commit/b1d8f40484dfcb28b19c83aa33a674308b17e5dc.diff LOG: Only run the weird new try-to-read-too-much test on Darwin I'm still getting linux CI bot failures for this test. It's not critical, and it depends on a failure mode that is true on Darwin but I was always gambling that it might fail in the same way on other systems. Added: Modified: lldb/test/API/python_api/process/TestProcessAPI.py Removed: ################################################################################ diff --git a/lldb/test/API/python_api/process/TestProcessAPI.py b/lldb/test/API/python_api/process/TestProcessAPI.py index 66f438a24f5b..afcc9d7cdee0 100644 --- a/lldb/test/API/python_api/process/TestProcessAPI.py +++ b/lldb/test/API/python_api/process/TestProcessAPI.py @@ -73,20 +73,21 @@ def test_read_memory(self): exe=False, startstr=b'x') - # Try to read an impossibly large amount of memory; swig - # will try to malloc it and fail, we should get an error - # result. - error = lldb.SBError() - bigsize = sys.maxsize - 8; - content = process.ReadMemory( - val.AddressOf().GetValueAsUnsigned(), - bigsize, error) - if error.Success(): - self.assertFalse(error.Success(), "SBProcessReadMemory claims to have " - "successfully read 0x%x bytes" % bigsize) - if self.TraceOn(): - print("Tried to read 0x%x bytes, got error message: %s" % - (bigsize, error.GetCString())) + if self.platformIsDarwin(): + # Try to read an impossibly large amount of memory; swig + # will try to malloc it and fail, we should get an error + # result. + error = lldb.SBError() + bigsize = sys.maxsize - 8; + content = process.ReadMemory( + val.AddressOf().GetValueAsUnsigned(), + bigsize, error) + if error.Success(): + self.assertFalse(error.Success(), "SBProcessReadMemory claims to have " + "successfully read 0x%x bytes" % bigsize) + if self.TraceOn(): + print("Tried to read 0x%x bytes, got error message: %s" % + (bigsize, error.GetCString())) # Read (char *)my_char_ptr. val = frame.FindValue("my_char_ptr", lldb.eValueTypeVariableGlobal) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
