Author: Stefan Gränitz Date: 2023-03-17T14:40:17+01:00 New Revision: c9987f0ac81a3d00be7627022372551bed61e6c1
URL: https://github.com/llvm/llvm-project/commit/c9987f0ac81a3d00be7627022372551bed61e6c1 DIFF: https://github.com/llvm/llvm-project/commit/c9987f0ac81a3d00be7627022372551bed61e6c1.diff LOG: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl() The old name of this function was confusing for me, when I started working on the PDB parser. The new name clearifies that the function adds file, line and column (typically referred as source info) and indicates that the information is stored in the provided decl parameter. Reviewed By: DavidSpickett Differential Revision: https://reviews.llvm.org/D146286 Added: Modified: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp b/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp index c9236da4842cf..da57338ffb58a 100644 --- a/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp +++ b/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp @@ -190,8 +190,7 @@ static ConstString GetPDBBuiltinTypeName(const PDBSymbolTypeBuiltin &pdb_type, return compiler_type.GetTypeName(); } -static bool GetDeclarationForSymbol(const PDBSymbol &symbol, - Declaration &decl) { +static bool AddSourceInfoToDecl(const PDBSymbol &symbol, Declaration &decl) { auto &raw_sym = symbol.getRawSymbol(); auto first_line_up = raw_sym.getSrcLineOnTypeDefn(); @@ -464,7 +463,7 @@ lldb::TypeSP PDBASTParser::CreateLLDBTypeFromPDBType(const PDBSymbol &type) { if (udt->isVolatileType()) clang_type = clang_type.AddVolatileModifier(); - GetDeclarationForSymbol(type, decl); + AddSourceInfoToDecl(type, decl); return m_ast.GetSymbolFile()->MakeType( type.getSymIndexId(), ConstString(name), udt->getLength(), nullptr, LLDB_INVALID_UID, lldb_private::Type::eEncodingIsUID, decl, clang_type, @@ -533,7 +532,7 @@ lldb::TypeSP PDBASTParser::CreateLLDBTypeFromPDBType(const PDBSymbol &type) { if (enum_type->isVolatileType()) ast_enum = ast_enum.AddVolatileModifier(); - GetDeclarationForSymbol(type, decl); + AddSourceInfoToDecl(type, decl); return m_ast.GetSymbolFile()->MakeType( type.getSymIndexId(), ConstString(name), bytes, nullptr, LLDB_INVALID_UID, lldb_private::Type::eEncodingIsUID, decl, ast_enum, @@ -579,7 +578,7 @@ lldb::TypeSP PDBASTParser::CreateLLDBTypeFromPDBType(const PDBSymbol &type) { if (type_def->isVolatileType()) ast_typedef = ast_typedef.AddVolatileModifier(); - GetDeclarationForSymbol(type, decl); + AddSourceInfoToDecl(type, decl); std::optional<uint64_t> size; if (type_def->getLength()) size = type_def->getLength(); @@ -659,7 +658,7 @@ lldb::TypeSP PDBASTParser::CreateLLDBTypeFromPDBType(const PDBSymbol &type) { m_ast.CreateFunctionType(return_ast_type, arg_list.data(), arg_list.size(), is_variadic, type_quals, cc); - GetDeclarationForSymbol(type, decl); + AddSourceInfoToDecl(type, decl); return m_ast.GetSymbolFile()->MakeType( type.getSymIndexId(), ConstString(name), std::nullopt, nullptr, LLDB_INVALID_UID, lldb_private::Type::eEncodingIsUID, decl, _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
