aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
You could add a test similar to
lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp
================
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:154
+ /// case this function should behave identically as ParseLanguage.
+ virtual llvm::SmallSet<lldb::LanguageType, 2>
+ ParseAllLanguages(CompileUnit &comp_unit) {
----------------
I would increase the set size to 4. It's quite common to have C, C++, and ObjC
in the same module.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146265/new/
https://reviews.llvm.org/D146265
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
