aprantl added inline comments.
================ Comment at: lldb/source/Core/DumpRegisterValue.cpp:136-137 + // See if we have made this type before and can reuse it. + CompilerType fields_type = ast->GetTypeForIdentifier<clang::CXXRecordDecl>( + ConstString(register_type_name.c_str())); + ---------------- bulbazord wrote: > This seems highly specific to C++... Let's try to find another way to do > this, ideally with `TypeSystem` instead of `TypeSystemClang` and > `clang::CXXRecordDecl`. Are we saving a lot of code by going through the clang typesystem here, or would walking the bits and formatting the directly be roughly the same amount of code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
