Michael137 added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:434 + CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 + LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ + endif ---------------- fdeazeve wrote: > Michael137 wrote: > > Should we add a hard error if we get here with an empty `SDKROOT`? > I thought about this, but at the start of this file we have this: > > ``` > # Handle SDKROOT on Darwin > #---------------------------------------------------------------------- > > ifeq "$(OS)" "Darwin" > ifeq "$(SDKROOT)" "" > # We haven't otherwise set the SDKROOT, so set it now to macosx > SDKROOT := $(shell xcrun --sdk macosx --show-sdk-path) > endif > endif > ``` > > So it would be a bit redundant... > But I think you're right that we could have an error in case someone, > someday, changes the logic above. Yea don't feel too strongly about it, since as you say, the check is at the top of the file already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
