JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
Thanks. This LGTM. ================ Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:856 + // user_size == 16 -> aligned_size == 16 + aligned_size = 1ULL << (addr_bit_size - __builtin_clzll(aligned_size - 1)); + ---------------- jasonmolenda wrote: > tschuett wrote: > > JDevlieghere wrote: > > > Beautiful. Once we have C++20 we can use `std::bit_ceil` > > > (https://en.cppreference.com/w/cpp/numeric/bit_ceil) > > Is the builtin available on all supported platforms and compilers? There > > are some alignment functions in MathExtras.h. > Ah, that would be very nice and a lot clearer for readers. I might add that > as a comment. Yes: `debugserver` is only supported on macOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149040/new/ https://reviews.llvm.org/D149040 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
