wallace added inline comments.
================ Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext &exe_ctx, llvm::StringRef code, + const EvaluateExpressionOptions &expr_options, + lldb::ExpressionResults execution_results, + const lldb::ValueObjectSP &result_valobj_sp, + const Status &error) {} ---------------- bulbazord wrote: > Why not return a `Status` object instead of having the return type be `void`? > Or instead of `Status` you could use `llvm::Error` so we are forced to check > it. my initial idea was to make this a simple observer, but a llvm::Error is probably more generic. I'll do that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149719/new/ https://reviews.llvm.org/D149719 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits