JDevlieghere added a comment.

Given that here we know the `total_progress` in advance and assuming the 
operation is relatively evenly distributed, would it make sense to report for 
every percentage? We could do this in `ManualDWARFIndex::Index` or we could add 
something like a "Policy" or "Granularity" to the progress class (similar to 
what `report_increment` is doing in this class). This seems preferable compared 
to the rather arbitrary value of report every `1000`.

I also like Jordan's rate limiting idea. In my mind that should be a property 
of the broadcaster. Different tools (e.g. vscode vs the command line) could 
specify different values when register a listener.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150805/new/

https://reviews.llvm.org/D150805

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to