bulbazord marked an inline comment as done. bulbazord added inline comments.
================ Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + ---------------- aprantl wrote: > Using an llvm string stream to construct the string might be faster here. I tested this and found that `llvm::SmallString<128>` performs about as well as `std::string` on average. `llvm::SmallString<64>` was on average slower though. I think I'm going to land this with std::string, we can revisit later if the difference actually is measurable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
