bulbazord added a comment. In D151615#4378441 <https://reviews.llvm.org/D151615#4378441>, @kastiglione wrote:
> Do you have something in mind? I figured the test suite was enough. Do you > mean stress for perf, or for ensuring this change has no behavior regressions? I meant stress test for perf. Behavior-wise I think the test suite should catch anything major. I'd be surprised if this changed behavior since you're passing the same data around but in a different form. >> We should probably change `CompilerType::GetIndexOfChildMemberWithName` to >> take a `StringRef` instead of a `const char *` as a follow-up. > > I made the same observation. I figured this change was big enough and was > also a single semantic change, so I didn't scope it out any further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151615/new/ https://reviews.llvm.org/D151615 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
