kastiglione added inline comments.
================
Comment at: lldb/include/lldb/Core/ValueObject.h:483
// this will always create the children if necessary
- lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef<ConstString> names,
- ConstString *name_of_error = nullptr);
+ lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef<llvm::StringRef>
names);
----------------
Michael137 wrote:
> Guessing removing the parameter is fine because no callers were actually
> passing it?
I forgot I had made this change too. Correct, no callers were using this, so I
removed it. I can imagine there could be a hypothetical case that uses it to
determine a fallback action, but none do and it seems unlikely.
================
Comment at: lldb/source/Core/ValueObject.cpp:434
ValueObjectSP root(GetSP());
- for (ConstString name : names) {
+ for (auto name : names) {
root = root->GetChildMemberWithName(name, true);
----------------
JDevlieghere wrote:
> I don’t think this qualifies for ‘auto’ according to the LLVM coding
> guidelines.
I find the guidelines to be not specific enough. Case in point, this section
shows `auto` being used in range for loops:
https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151813/new/
https://reviews.llvm.org/D151813
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
