JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with the other two functions updated as well.
================
Comment at: lldb/include/lldb/Target/Platform.h:453
- void SetSDKRootDirectory(ConstString dir) { m_sdk_sysroot = dir; }
+ void SetSDKRootDirectory(llvm::StringRef dir) { m_sdk_sysroot = dir.str(); }
----------------
================
Comment at: lldb/include/lldb/Target/Platform.h:457
- void SetSDKBuild(ConstString sdk_build) { m_sdk_build = sdk_build; }
+ void SetSDKBuild(llvm::StringRef sdk_build) { m_sdk_build = sdk_build.str();
}
----------------
std::string
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152331/new/
https://reviews.llvm.org/D152331
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
