This revision was automatically updated to reflect the committed changes. Closed by commit rGf2a1320c2ff5: [lldb] De-virtualize applicable functions in ValueObject (NFC) (authored by kastiglione).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153088/new/ https://reviews.llvm.org/D153088 Files: lldb/include/lldb/Core/ValueObject.h Index: lldb/include/lldb/Core/ValueObject.h =================================================================== --- lldb/include/lldb/Core/ValueObject.h +++ lldb/include/lldb/Core/ValueObject.h @@ -370,26 +370,26 @@ return GetCompilerType().GetTypeName(); } - virtual lldb::LanguageType GetObjectRuntimeLanguage() { + lldb::LanguageType GetObjectRuntimeLanguage() { return GetCompilerType().GetMinimumLanguage(); } - virtual uint32_t + uint32_t GetTypeInfo(CompilerType *pointee_or_element_compiler_type = nullptr) { return GetCompilerType().GetTypeInfo(pointee_or_element_compiler_type); } - virtual bool IsPointerType() { return GetCompilerType().IsPointerType(); } + bool IsPointerType() { return GetCompilerType().IsPointerType(); } - virtual bool IsArrayType() { return GetCompilerType().IsArrayType(); } + bool IsArrayType() { return GetCompilerType().IsArrayType(); } - virtual bool IsScalarType() { return GetCompilerType().IsScalarType(); } + bool IsScalarType() { return GetCompilerType().IsScalarType(); } - virtual bool IsPointerOrReferenceType() { + bool IsPointerOrReferenceType() { return GetCompilerType().IsPointerOrReferenceType(); } - virtual bool IsPossibleDynamicType(); + bool IsPossibleDynamicType(); bool IsNilReference(); @@ -429,10 +429,6 @@ return (GetBitfieldBitSize() != 0) || (GetBitfieldBitOffset() != 0); } - virtual bool IsArrayItemForPointer() { - return m_flags.m_is_array_item_for_pointer; - } - virtual const char *GetValueAsCString(); virtual bool GetValueAsCString(const lldb_private::TypeFormatImpl &format, @@ -628,7 +624,7 @@ // The backing bits of this value object were updated, clear any descriptive // string, so we know we have to refetch them. - virtual void ValueUpdated() { + void ValueUpdated() { ClearUserVisibleData(eClearUserVisibleDataItemsValue | eClearUserVisibleDataItemsSummary | eClearUserVisibleDataItemsDescription);
Index: lldb/include/lldb/Core/ValueObject.h =================================================================== --- lldb/include/lldb/Core/ValueObject.h +++ lldb/include/lldb/Core/ValueObject.h @@ -370,26 +370,26 @@ return GetCompilerType().GetTypeName(); } - virtual lldb::LanguageType GetObjectRuntimeLanguage() { + lldb::LanguageType GetObjectRuntimeLanguage() { return GetCompilerType().GetMinimumLanguage(); } - virtual uint32_t + uint32_t GetTypeInfo(CompilerType *pointee_or_element_compiler_type = nullptr) { return GetCompilerType().GetTypeInfo(pointee_or_element_compiler_type); } - virtual bool IsPointerType() { return GetCompilerType().IsPointerType(); } + bool IsPointerType() { return GetCompilerType().IsPointerType(); } - virtual bool IsArrayType() { return GetCompilerType().IsArrayType(); } + bool IsArrayType() { return GetCompilerType().IsArrayType(); } - virtual bool IsScalarType() { return GetCompilerType().IsScalarType(); } + bool IsScalarType() { return GetCompilerType().IsScalarType(); } - virtual bool IsPointerOrReferenceType() { + bool IsPointerOrReferenceType() { return GetCompilerType().IsPointerOrReferenceType(); } - virtual bool IsPossibleDynamicType(); + bool IsPossibleDynamicType(); bool IsNilReference(); @@ -429,10 +429,6 @@ return (GetBitfieldBitSize() != 0) || (GetBitfieldBitOffset() != 0); } - virtual bool IsArrayItemForPointer() { - return m_flags.m_is_array_item_for_pointer; - } - virtual const char *GetValueAsCString(); virtual bool GetValueAsCString(const lldb_private::TypeFormatImpl &format, @@ -628,7 +624,7 @@ // The backing bits of this value object were updated, clear any descriptive // string, so we know we have to refetch them. - virtual void ValueUpdated() { + void ValueUpdated() { ClearUserVisibleData(eClearUserVisibleDataItemsValue | eClearUserVisibleDataItemsSummary | eClearUserVisibleDataItemsDescription);
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits