Author: Jonas Devlieghere Date: 2023-07-30T14:15:34-07:00 New Revision: b96ea7e1f1351cec89100097936524122a850225
URL: https://github.com/llvm/llvm-project/commit/b96ea7e1f1351cec89100097936524122a850225 DIFF: https://github.com/llvm/llvm-project/commit/b96ea7e1f1351cec89100097936524122a850225.diff LOG: [lldb] Remove workaround in InstrumentationRuntimeASan The code was commented out because it would trigger an assert in the source manager. I can no longer reproduce the assert and none of the ASan tests are failing with the code re-enabled. Added: Modified: lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp b/lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp index 44070b42222018..10ff1ca7d5d438 100644 --- a/lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp +++ b/lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp @@ -152,12 +152,10 @@ StructuredData::ObjectSP InstrumentationRuntimeASan::RetrieveReportData() { addr_t pc = return_value_sp->GetValueForExpressionPath(".pc")->GetValueAsUnsigned(0); - /* commented out because rdar://problem/18533301 addr_t bp = return_value_sp->GetValueForExpressionPath(".bp")->GetValueAsUnsigned(0); addr_t sp = - return_value_sp->GetValueForExpressionPath(".sp")->GetValueAsUnsigned(0); - */ + return_value_sp->GetValueForExpressionPath(".sp")->GetValueAsUnsigned(0); addr_t address = return_value_sp->GetValueForExpressionPath(".address") ->GetValueAsUnsigned(0); addr_t access_type = @@ -177,10 +175,8 @@ StructuredData::ObjectSP InstrumentationRuntimeASan::RetrieveReportData() { dict->AddStringItem("instrumentation_class", "AddressSanitizer"); dict->AddStringItem("stop_type", "fatal_error"); dict->AddIntegerItem("pc", pc); - /* commented out because rdar://problem/18533301 dict->AddIntegerItem("bp", bp); dict->AddIntegerItem("sp", sp); - */ dict->AddIntegerItem("address", address); dict->AddIntegerItem("access_type", access_type); dict->AddIntegerItem("access_size", access_size); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
