Author: Jonas Devlieghere Date: 2023-07-30T15:25:08-07:00 New Revision: b699bf671aa074f41433c6469707a7a2110ffa42
URL: https://github.com/llvm/llvm-project/commit/b699bf671aa074f41433c6469707a7a2110ffa42 DIFF: https://github.com/llvm/llvm-project/commit/b699bf671aa074f41433c6469707a7a2110ffa42.diff LOG: [lldb] Replace another inconsequential radar link (NFC) The existing comment already explains what the problem is. The radar tracks caching negative lookups in xcrun. Having a backlink is handy, but it's not necessary as the radar references the LLDB workaround. Furthermore, we have other places in LLDB that work around xcrun not caching negative that should potentially be reconsidered at that time. Added: Modified: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp index 7044426e17b501..1348eca05e337f 100644 --- a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp +++ b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp @@ -545,7 +545,7 @@ static bool shouldSkipSimulatorPlatform(bool force, const ArchSpec *arch) { // If the arch is known not to specify a simulator environment, skip creating // the simulator platform (we can create it later if there's a matching arch). // This avoids very slow xcrun queries for non-simulator archs (the slowness - // is due to xcrun not caching negative queries (rdar://74882205)). + // is due to xcrun not caching negative queries. return !force && arch && arch->IsValid() && !arch->TripleEnvironmentWasSpecified(); } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
